This repository was archived by the owner on Oct 4, 2021. It is now read-only.
[release-8.4] [Core] Avoid showing duplicated files in project tree #9310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases where, it seems, we don't evaluate conditions as we should, resulting in duplicated items being added to the project and, thus, also shown in the project tree (see dotnet/aspnetcore#17088). Also, by just adding a <None Include="*"/>, duplicated files show also. So, due to this limitation on the project system, work around it on the project tree, by checking for duplicates based on the files' paths. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1005277
monojenkins
force-pushed
the
backport-pr-9309-to-release-8.4
branch
from
31adb56 to
90f09d7
Compare
Member
|
I'm not sure this is correct, the issue should be fixed in the project system. I'd like @mrward to take a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where, it seems, we don't evaluate conditions as we should,
resulting in duplicated items being added to the project and, thus, also shown
in the project tree (see dotnet/aspnetcore#17088).
Also, by just adding a , duplicated files show also.
So, due to this limitation on the project system, work around it on the project
tree, by checking for duplicates based on the files' paths.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1005277
Backport of #9309.
/cc @rodrmoya